search

plone / plone.app.multilingual

Plone Multilingual Content Add-on
https://pypi.org/project/plone.app.multilingual
19 stars 47 forks source link

Add translation permission to Site Administrator role #406

Closed davisagli closed 2 years ago

mister-roboto commented 2 years ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

davisagli commented 2 years ago

@jenkins-plone-org please run jobs

erral commented 2 years ago

This will require an upgrade step, right?

davisagli commented 2 years ago

@erral I could see the argument either way on the upgrade step. If someone customized the roles for this permission in an existing site, maybe we should not overwrite that.

erral commented 2 years ago

Then we should, at least, document in the README or CHANGELOG this change and document how to apply the change for existing sites. Something like "an optional upgrade step to run" or...

davisagli commented 2 years ago

@erral I updated the changelog