search

plone / plone.app.querystring

Provides an queryparser, querybuilder and extra helper tools, to parse stored queries to actual results, used in new style Plone collections
https://pypi.org/project/plone.app.querystring/
2 stars 26 forks source link

Fixes #111 for branch 1.x #112

Closed erral closed 2 years ago

erral commented 2 years ago

I just copied over the function munge_search_terms from https://github.com/plone/Products.CMFPlone/pull/3518

We are using the same plone.app.querystring version for both Plone 5.2.x and 6, so it is not possible to import from Products.CMFPlone and neither from plone.base if that function is ever moved to there.

Opinions? @petschki @jensens @mauritsvanrees

mister-roboto commented 2 years ago

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

erral commented 2 years ago

@jenkins-plone-org please run jobs

erral commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

For master branch (=Plone 6 only) I'd import the existing utility from Products.CMFPlone.browser.search and bump the version to 2.0.0dev0

If this munge_search_term is used here too, maybe we should move it now to plone.base ? /cc @jensens

erral commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

The one remaining failing test on 2.7 is an unrelated robot failure that we can ignore. Has nothing to do with this PR.

erral commented 2 years ago

Ok, I will change to be a method, create the 1.x branch for 5.2, port the change to master and bump it to 6 only

erral commented 2 years ago

@jenkins-plone-org please run jobs

erral commented 2 years ago

PR updated and PR for buildout.coredev also in place: https://github.com/plone/buildout.coredev/pull/805

erral commented 2 years ago

@jenkins-plone-org please run jobs

erral commented 2 years ago

@jenkins-plone-org please run jobs

erral commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

It could go to plone.base for Plone 6. I agree to branch away to 1.x and backport as done here.