search

plone / plone.app.querystring

Provides an queryparser, querybuilder and extra helper tools, to parse stored queries to actual results, used in new style Plone collections
https://pypi.org/project/plone.app.querystring/
2 stars 26 forks source link

Use `munge_search_term` from CMFPlone #115

Closed petschki closed 1 year ago

petschki commented 2 years ago

I've brought back the changes from @erral to this new PR for Plone 6 ...

mister-roboto commented 2 years ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

The robot failures seem unrelated, but all three jobs failing is a bit much. Let's try again.

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

oh my ... I've added experimental github actions workflow ... at least 2 coredevs are green ... locally I cannot reproduce the robot failures ...

mauritsvanrees commented 2 years ago

We probably should not add GH actions here, so we should remove it before merge. But it is good to know that the 3.9 and 3.10 jobs passed. I restarted the failing actions. And let's try Jenkins again. There are no other jobs running currently, that may help.

@jenkins-plone-org please run jobs

petschki commented 2 years ago

Will do.

petschki commented 2 years ago

maybe we get one green ...

@jenkins-plone-org please run jobs

petschki commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

Only 3.7 has unrelated robot failures now. I merge.