search

plone / plone.app.querystring

Provides an queryparser, querybuilder and extra helper tools, to parse stored queries to actual results, used in new style Plone collections
https://pypi.org/project/plone.app.querystring/
2 stars 26 forks source link

Housecleaning #119

Closed jensens closed 1 year ago

jensens commented 1 year ago
mister-roboto commented 1 year ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 1 year ago

@jenkins-plone-org please run jobs

gforcada commented 1 year ago

Thanks for adding this, though, if we don't do it via plone/meta the next contribution might break pyupgrade/isort/black/etc and no one will notice, getting worse and worse by each contribution and finally having to create yet another clean up PR 😵‍💫

Let's merge this and I will create a follow up PR with the missing bits 👍🏾

gforcada commented 1 year ago

@jenkins-plone-org please run jobs