Closed gforcada closed 1 year ago
@gforcada thanks for creating this Pull Request and helping to improve Plone!
TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
@jenkins-plone-org please run jobs
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.
Happy hacking!
I am running PR tests for these three together:
Jenkins passes, but the gh-actions tests fail, also locally:
Failure in test test__navigationPath (plone.app.querystring.tests.testQueryParser.TestQueryGenerators)
Traceback (most recent call last):
File "/usr/local/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 59, in testPartExecutor
yield
File "/usr/local/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 591, in run
self._callTestMethod(testMethod)
File "/usr/local/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 549, in _callTestMethod
method()
File "/Users/maurits/community/plone-coredev/6.0/src/plone.app.querystring/plone/app/querystring/tests/testQueryParser.py", line 535, in test__navigationPath
self.assertEqual(parsed, expected)
File "/usr/local/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 845, in assertEqual
assertion_func(first, second, msg=msg)
File "/usr/local/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 1144, in assertDictEqual
self.fail(self._formatMessage(msg, standardMsg))
File "/usr/local/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/unittest/case.py", line 675, in fail
raise self.failureException(msg)
AssertionError: {'path': {'query': ['//bar/']}} != {'path': {'query': ['/site/foo/bar/']}}
- {'path': {'query': ['//bar/']}}
+ {'path': {'query': ['/site/foo/bar/']}}
? ++++++++
Ah, right, we need a new release of plone.app.layout
in 6.0-dev. I will see to that.
@ale-rt some tests fail to run because
zpretty
reformatted a few files and added autf-8
encoding declaration andlxml
refuses to parse them as text, but suggests that they should be send tolxml
asbytes
rather.Should we adapt the tests to parse the files as bytes, or rather should
zpretty
not add thoseutf-8
encoding declarations? 🤔🍀