Fix a circular dependency to plone.app.vocabularies

plone / plone.app.querystring

Provides an queryparser, querybuilder and extra helper tools, to parse stored queries to actual results, used in new style Plone collections

https://pypi.org/project/plone.app.querystring/

2 stars 26 forks source link

Fix a circular dependency to plone.app.vocabularies #124

Closed jensens closed 1 year ago

jensens commented 1 year ago

New direct dependency explicit on plone.app.vocabularies.
Move plone.app.vocabularies.catalog.CatalogVocabularyFactory to .vocabularies, move the ZCML to register the factory, move the the test.
Move plone.app.vocabularies.utils.parse_query with new name parseAndModifyFormquery to .queryparser.

Has to be tested and merged together with https://github.com/plone/plone.app.vocabularies/pull/76 GHA test will fail.

mister-roboto commented 1 year ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!