search

plone / plone.app.querystring

Provides an queryparser, querybuilder and extra helper tools, to parse stored queries to actual results, used in new style Plone collections
https://pypi.org/project/plone.app.querystring/
2 stars 26 forks source link

Create string search operator #148

Closed instification closed 3 weeks ago

instification commented 1 month ago

Currently the only operator for searching strings is the contains operator which modifies the search term before running the query.

The creation of a search operator allows a search to be performed without munging the search term. This allows for exact matching in searches.

The primary use case for driving this PR is to be able to provide the search term to collective.elasticsearch without modification so that elastic can be used to parse the search original phrase.

mister-roboto commented 1 month ago

@instification thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

instification commented 3 weeks ago

Closing this PR. As per review comments this functionality is best suited elsewhere