search

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.
https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html
11 stars 17 forks source link

Remove deprecation warnings #117

Closed ale-rt closed 4 years ago

ale-rt commented 4 years ago

Fixes #116

mister-roboto commented 4 years ago

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

ale-rt commented 4 years ago

@jenkins-plone-org please run jobs

datakurre commented 4 years ago

Or does this only affect tests of this package?

ale-rt commented 4 years ago

@asko this PR is only about removing deprecation warnings you will see when using this package in Plone 5.2. So it is just updating the import locations.

I left 5.1 compatibility because the package is still tested on travis with Plone 5.1 (#118 is an attempt to fix this). About the ZServer support I suspect it is already gone in plone.testing.

It is a matter of fact that current master with the latest plone.testing in Plone5.2 is using the WSGI_SERVER_FIXTURE because of this line: https://github.com/plone/plone.testing/blob/master/src/plone/testing/z2.py#L29