Fixed error "Variable '${CMFPLONE_SELECTORS}' not found" on Plone 6.

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.

https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html

11 stars 17 forks source link

Fixed error "Variable '${CMFPLONE_SELECTORS}' not found" on Plone 6. #121

Closed mauritsvanrees closed 3 years ago

mauritsvanrees commented 3 years ago

This is some example selector. On Plone 6 the variable was not defined. It makes all robot tests on Plone 6 broken, see https://github.com/plone/buildout.coredev/pull/680

[ ERROR ] Error in file
'/Users/maurits/community/plone-coredev/6.0/src/plone.app.robotframework/src/plone/app/robotframework/selenium.robot':
Replacing variables from setting 'Resource' failed: Variable '${CMFPLONE_SELECTORS}' not found.

mister-roboto commented 3 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 3 years ago

@jenkins-plone-org please run jobs

And while that is running, let me note an alternative: completely remove this. This code was introduced in commit e99e476b2329ba155fc5b6c161748b8d0f8f53bb in 2014 and afterwards never changed. It was committed by @datakurre for @tisto. It looks like a proof of concept. Was this ever used?