search

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.
https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html
11 stars 17 forks source link

Cleanup: PY3/dexterity only, isort, black #129

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

Best look at the individual commits.

mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 2 years ago

We should update Plone 6 to use a much newer robotframework version. But first, let's do this cleanup. Master branch is already for Plone 6 only. Let's try to keep compatibility with Plone 5.2 and Python 3.6, as we may need to run the plone.restapi tests with it on those versions.

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

Try again after a fix:

@jenkins-plone-org please run jobs