search

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.
https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html
11 stars 17 forks source link

Make compatible with robotframework 3-5 #130

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

This includes the commits from PR #129, which is green.

I will test this PR in combination with a few others.

mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 2 years ago

I am testing these in combination:

https://github.com/plone/plone.app.robotframework/pull/130
https://github.com/plone/plone.app.multilingual/pull/400
https://github.com/plone/plone.app.dexterity/pull/349
https://github.com/plone/plone.schemaeditor/pull/88
https://github.com/plone/plone.app.discussion/pull/197
https://github.com/plone/Products.CMFPlone/pull/3519
gforcada commented 2 years ago

Great job! 🌟

mauritsvanrees commented 2 years ago

Thanks for the reviews!