Config with default template

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.

https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html

11 stars 17 forks source link

Config with default template #145

Closed gforcada closed 11 months ago

gforcada commented 1 year ago

@datakurre I hope that deleting the buildout configuration is fine, if you can also double check the dependencies it would be great as well ✨

Tests seem to fail locally, not sure if they need more dependencies, or rather more time to run ? 🤔

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

@jenkins-plone-org please run jobs

gforcada commented 11 months ago

I removed 3 GHA to get this to pass:

tests / coverage: somehow they do not run fine on GHA 🤔 but do pass on Jenkins 🤷🏾
circular dependencies: there is one such between Products.CMFPlone and plone.app.multilingual ⛓️

Without these actions, the PR should pass fine and thus we can start benefiting from plone/meta DevX 🥳

gforcada commented 11 months ago

@jenkins-plone-org please run jobs