search

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.
https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html
11 stars 17 forks source link

Avoid duplicate installation of plone.app.contenttypes profile #154

Closed davisagli closed 9 months ago

davisagli commented 9 months ago

In Plone 6, the plone.app.contenttypes profile is already installed by the PLONE_FIXTURE. So it's not necessary for SimplePublicationLayer to install it again.

This avoids printing a warning that plone.app.event is already installed, and avoids some unnecessary work.

mister-roboto commented 9 months ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

davisagli commented 9 months ago

@jenkins-plone-org please run jobs