Run tests with Dexterity

[tisto]

All robot and integration tests currently run against Archetypes. Since I'm using Dexterity exclusively, writing tests for Archetypes seems a bit strange.

@datakurre Would you mind if we switch the tests to Dexterity? Another option of course is to run all tests against both, which means writing most of the tests twice. Though, this is too much work in my opinion (Archetypes is dead!).

[datakurre]

We are talking about tests in p.a.robotframework?

Mostly :+1:

I'd still want to keep dexterity as an optional and test dependency (which it might not be right now, because some mistakes some time ago).

Of course, at first, you could try to just reuse the existing tests with a Dexterity enabled layer. Like I'm trying to run CMFPlone tests against Mosaic: https://github.com/plone/plone.app.mosaic/blob/master/src/plone/app/mosaic/tests/test_robot.py

I would like to still delay bringing plone.app.contenttypes into test dependencies, because it's still a quite dependency mess for Plone 4.

[tisto]

Yes. It's about the p.a.robotframework tests.

Yeah. That's true. p.a.contenttypes/plone.app.event dependencies are a pita. Though, even if we add optional Dexterity tests, we still would have to take care of that. What about just using Dexterity (without p.a.contenttypes)?

[datakurre]

:+1:

Actually, I adding dexterity as a test dependency seems to be what I have in progress. I'll be back shortly.

Timo Stollenwerk wrote:

Yes. It's about the p.a.robotframework tests.

Yeah. That's true. p.a.contenttypes/plone.app.event dependencies are a pita. Though, even if we add optional Dexterity tests, we still would have to take care of that. What about just using Dexterity (without p.a.contenttypes)?

— Reply to this email directly or view it on GitHub https://github.com/plone/plone.app.robotframework/issues/27#issuecomment-47626674.

[tisto]

Ok. Cool. Let me know if there is anything I can do to help.

[datakurre]

@tisto

Ok. I started that small refactoring so long ago that small I don't remember anymore what I was really doing :)

p.a.robotframework has no [test] extras, which include Dexterity, but all modules use wrap Dexterity dependencies under HAS_DEXTERITY condition.

You are free to continue on this issue now, when you are working with this at the next time :)

Timo Stollenwerk wrote:

Ok. Cool. Let me know if there is anything I can do to help.

— Reply to this email directly or view it on GitHub https://github.com/plone/plone.app.robotframework/issues/27#issuecomment-47627740.

[tisto]

@datakurre Just to be clear: I can make Dexterity a test dependency and move all tests to rely on Dexterity instead of Archetypes?

[datakurre]

@tisto

Yes. Dexterity is already a test dependency. All I want is that you can still safely import all modules (including testing.py) without Dexterity.

-Asko

Timo Stollenwerk wrote:

@datakurre https://github.com/datakurre Just to be clear: I can make Dexterity a test dependency and move all tests to rely on Dexterity instead of Archetypes?

— Reply to this email directly or view it on GitHub https://github.com/plone/plone.app.robotframework/issues/27#issuecomment-47639406.

[jensens]

is this one worth to be kept open? IIRC it's not a problem these days. i

[tisto]

@jensens if we still run our tests against AT for sure!

[jensens]

@tisto As long as Archetypes is not officially unsupported, sure, we must run all tests against AT as well.

[tisto]

@jensens we do NOT run tests against Dexterity at all, that's the point of this ticket. I would really appreciate if you would not close a ticket right after I told you that I want to keep it open.

[jensens]

Sorry, I understood the opposite.

[tisto]

@jensens no problem. :) Thanks for putting so much effort into updating and closing tickets. This is highly appreciated!