search

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.
https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html
11 stars 17 forks source link

Removed bad format parameter on ObjectModifiedEvent #54

Closed sgeulette closed 8 years ago

sgeulette commented 8 years ago

The format of the second parameter on ObjectModifiedEvent can't be a dict. It must be an Attributes instance: ObjectModifiedEvent(obj, Attributes(ISample, "field")) (zope.lifecycleevent.init.py). As we can't have the field interface or the full fieldname, we can't add an Attributes instance. I have removed the parameter...

datakurre commented 8 years ago

@sgeulette Oops, sorry. I forgot to ask, have you signed the contributor agreement.

sgeulette commented 8 years ago

Yes, I have signed it. Thanks

sgeulette commented 8 years ago

It could be nice to have a published list of persons who have signed...

gforcada commented 8 years ago

@sgeulette if you are a member of https://github.com/plone organization it means that you have signed it. If you are not but have signed it, somehow you were lost in the limbo, @ableeb can you confirm that @sgeulette has indeed signed the CLA and add him to the plone org?

gforcada commented 8 years ago

@sgeulette @ableeb Uh, sorry, I should have checked before asking... @sgeulette you are already part of plone organization, probably @datakurre thought you were not as the plone organization is not shown on your github member profile, it would be nice if you show it there, so it's easier to know if you are or not a Plone member.

sgeulette commented 8 years ago

@gforcada @datakurre I have plone in my organizations. Is it not visible ?

gforcada commented 8 years ago

@sgeulette I can only see collective, plonegov and imio: orgs

gforcada commented 8 years ago

@sgeulette see https://help.github.com/articles/publicizing-or-hiding-organization-membership/

sgeulette commented 8 years ago

@gforcada ok, thanks. It should now be visible.

datakurre commented 8 years ago

@sgeulette Thanks. Merged.