plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.
https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html
11 stars 17 forks source link

Deprecate "I'm logged in as..."? #67

Open tisto opened 7 years ago

tisto commented 7 years ago

We currently have two ways of defining a precondition for a logged in user:

I'm logged in as a 'Site Administrator'

or

a logged in site administrator

Both keywords use past tense, which is considered best practice for GIVEN keywords in BDD. Though, the "I do something" is usually reserved for WHEN keywords to indicate an action of a user. Therefore if we want to use this keyword in GIVEN, we should stick to the second option and deprecate the first option to avoid confusion. What do you think @datakurre?

datakurre commented 7 years ago

:+1: