Create user with roles - Githubissues

plone / plone.app.robotframework

Provides Robot Framework compatible resources and tools for writing functional Selenium tests (including acceptance tests) for Plone CMS and its add-ons.

https://docs.plone.org/external/plone.app.robotframework/docs/source/index.html

11 stars 17 forks source link

Create user with roles #78

Closed ksuess closed 6 years ago

ksuess commented 6 years ago

Issue https://github.com/plone/plone.app.robotframework/issues/77

Create user siteadmin Contributor Reviewer Site Administrator
Create user siteadmin2 roles=('Contributor','Reviewer','Site Administrator')

None of the two creates a user as expected.

creates a user with roles ('Member',)
creates a user with roles ('Contributor','Reviewer','Site Administrator'), missing role 'Member'

ksuess commented 6 years ago

Hi @datakurre, please be so kind and make a review. thank you

datakurre commented 6 years ago

@ksuess Thanks for reminding us about this. And especially for adding tests.

Which version have you been using by yourself?

I will propose a few changes:

Use should have Member role only when roles are not explicitly defined. I believe this follows Plone defaults. Yet, we must be able to create users also without Member role.
kwargs should use Robot Framework list syntax instead of eval

I will write a pull for this pull.

datakurre commented 6 years ago

@ksuess Thanks for contribution and pushing to get this fixed.