search

plone / plone.app.standardtiles

Plone Standard tiles (reflecting viewlets et al) to be used with Plone Mosaic
Other
7 stars 12 forks source link

Replace dependency on noembed with python-oembed and list of providers #110

Open datakurre opened 3 years ago

datakurre commented 3 years ago

Embed tile has been depending on noembed-service, defaulting to the public service at https://noembed.com/ without instructions on how to host that by yourself.

This is an attempt to get rid of that service with pre-configured python-oembed consumer.

If accepted, I am not sure is this patch or a breaking change. Noembed.com seem to be not maintained anymore and there are immediate issues with it, requiring at least some fix. But then again, completely replacing it with embedded implementation is a breaking change.

https://community.plone.org/t/mosaic-embed-youtube-broke-noembed-com/13327/12

jensens commented 3 years ago

Thanks! This LGTM. Just the test needs some work, right?

datakurre commented 3 years ago

@jensens Yes. Tests and maybe also some real life tests that there is no regression. Although, this should support more oEmbed providers than noembed did :thinking:

Also, as mentioned, I am not sure if this is a patch, feature or breaking change.

jensens commented 3 years ago

I would consider this as breaking. If someone run its own noembed server before it is no longer needed. So, it does not hurt to do a major release.