search

plone / plone.app.standardtiles

Plone Standard tiles (reflecting viewlets et al) to be used with Plone Mosaic
Other
7 stars 12 forks source link

Simplified and fixed CI for Plone 5.1 and 5.2. #129

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

I have created a branch 4.x from current master, for supporting Plone 5.1 and 5.2. I have fixed tox.ini so it works again locally:

$ tox -p auto
✔ OK py36-Plone52 in 37.353 seconds
✔ OK py38-Plone52 in 39.052 seconds
✔ OK py37-Plone52 in 39.45 seconds
✔ OK py27-Plone52 in 45.096 seconds
✔ OK py27-Plone51 in 51.237 seconds
_______________ summary _______________
  py27-Plone51: commands succeeded
  py27-Plone52: commands succeeded
  py36-Plone52: commands succeeded
  py37-Plone52: commands succeeded
  py38-Plone52: commands succeeded
  congratulations :)

I have removed all linting, code-analysis, coverage. Various parts were pointing to a src directory that did not exist. If we want to keep doing this on the main, that is fine, but let's not burden the support branch with this. Also removed chromedriver/robot stuff from GitHub Actions, because we do not have any robot tests.

mauritsvanrees commented 2 years ago

Does anyone understand why GitHub Actions are not running? Jobs got started at first, but failed quickly because of various reasons. I fixed this and force pushed. But now no actions are running at all, except the standard changelog and contributor agreement verifiers. Does anyone see what I am doing wrong?

mauritsvanrees commented 2 years ago

Found it. The workflow file was invalid, which GitHub tells you if you know where to look.

The workflow is not valid. .github/workflows/main.yml (Line: 14, Col: 7):
A sequence was not expected

I was using matrix.config, but my matrix did not have a config.