search

plone / plone.app.standardtiles

Plone Standard tiles (reflecting viewlets et al) to be used with Plone Mosaic
Other
7 stars 12 forks source link

Problem: existingcontent __getattr__ is piling hacks #133

Closed gotcha closed 2 years ago

gotcha commented 2 years ago

Solution: get rid of it since it does not seem to be needed anymore

Add an error message for the corner case that might still break

(I'll make another PR for main branch if this gets accepted.)

gotcha commented 2 years ago

@mauritsvanrees Thanks for reviewing. I'd also appreciate another pair of eyes.

Further, would you mind reviewing the commit I added 1 minute after your review 😬 ?

mauritsvanrees commented 2 years ago

Further, would you mind reviewing the commit I added 1 minute after your review 😬 ?

Still seems to work. Tested on Plone 5.2.8, Python 3.8, plone.app.mosaic 2.2.3.

jensens commented 2 years ago

Merge after adding a changelog entry.