Fix some test isolation issues

plone / plone.app.testing

Testing tools for Plone-the-application

http://pypi.python.org/pypi/plone.app.testing

2 stars 7 forks source link

Fix some test isolation issues #64

Closed ale-rt closed 4 years ago

ale-rt commented 4 years ago

Fix a test isolation issue that was preventing the MOCK_MAILHOST_FIXTURE to be used in multiple testcases (Fixes #61),

Properly configure the mail sender setting the appropriate registry records (Fixes #62),

Adds test coverage.

mister-roboto commented 4 years ago

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

ale-rt commented 4 years ago

@jenkins-plone-org please run jobs

ale-rt commented 4 years ago

@jenkins-plone-org please run jobs

coveralls commented 4 years ago

Coverage increased (+3.4%) to 58.103% when pulling e8ba5ff36f90cababf725da4a7a4b3e6c1e3120c on isolation into 0395ca8c6dd872ddcb6fb8300f723669659ea6d9 on master.

coveralls commented 4 years ago

Coverage increased (+0.8%) to 55.515% when pulling 84beb2680a12536dd050f970173d44304746e0f7 on isolation into 0395ca8c6dd872ddcb6fb8300f723669659ea6d9 on master.

ale-rt commented 4 years ago

@jenkins-plone-org please run jobs

ale-rt commented 4 years ago

It seems to me the failing robot test is unrelated

ale-rt commented 4 years ago

Failing build https://jenkins.plone.org/job/pull-request-5.2-3.7/842/ I restarted it, pending execution (URL should be https://jenkins.plone.org/job/pull-request-5.2-3.7/846)