search

plone / plone.app.testing

Testing tools for Plone-the-application
http://pypi.python.org/pypi/plone.app.testing
2 stars 7 forks source link

Fixed test failure on Python 3 with Products.MailHost 4.10. #70

Closed mauritsvanrees closed 3 years ago

mauritsvanrees commented 4 years ago

Message is now bytes instead of string.

Part of https://github.com/plone/Products.CMFPlone/issues/3178 Needs to be merged in combination with other PRs mentioned there.

mister-roboto commented 4 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 4 years ago

@ale-rt Fast. :-)

mauritsvanrees commented 3 years ago

This was failing on Travis for two reasons:

  1. It is being tested here with the current coredev versions, so still the older Products.MailHost; that should be fixed automatically when we merge the coredev branch.
  2. Travis also fails because the lint jobs fail, but this has nothing to do with the PR itself. Okay, I made a change in tox.ini which should fix that.
mauritsvanrees commented 3 years ago

The Travis lint tests pass now.