search

plone / plone.app.testing

Testing tools for Plone-the-application
http://pypi.python.org/pypi/plone.app.testing
2 stars 7 forks source link

Load CMFFormController in Plone 5, be silent when this fails in Plone 6. #77

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

This restores compatibility with Plone 5.2 for now. Note that this plone.app.testing version is only meant for Python 3. (Technically I think it may still work on Python 2, but that can change at any moment.)

See discussion on issue 3467 starting here.

For me, this PR is not a promise to keep plone.app.testing 7.x working on Plone 5.2. I do not plan on adding this to the coredev 5.2 versions. But if this works, and the extra maintenance burden is low enough, then we can after a while make it a promise. Anyone should feel free to rip out Python 2 / Archetypes code though.

In a local test on 5.2 with this PR, bin/test -s Products.CMFPlone passed, so that is a good start.

mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 2 years ago

Let's run the tests on Plone 6 automatically:

@jenkins-plone-org please run jobs

And I will start the 5.2 jobs manually. Out of curiosity I will include testing it on 5.2-Py27, but I don't mind if that fails.

sneridagh commented 2 years ago

@mauritsvanrees whenever you can, if you can cut a release I'll test it out. Thanks!

mauritsvanrees commented 2 years ago

Oops, I meant to release this sooner. Feel free to remind me sooner next time. :-) I have released plone.app.testing 7.0.0a3.

sneridagh commented 2 years ago

@mauritsvanrees works like a charm both in 5 and 6!

sneridagh commented 2 years ago

Thanks a lot!