search

plone / plone.app.testing

Testing tools for Plone-the-application
http://pypi.python.org/pypi/plone.app.testing
2 stars 7 forks source link

PloneFixture: explicitly install plone.app.contenttypes:default. #97

Closed mauritsvanrees closed 3 months ago

mauritsvanrees commented 4 months ago

The addPloneSite factory in Plone 6.1 no longer installs this by default. See https://github.com/plone/Products.CMFPlone/issues/3961

Maybe we should only do this in Plone 6.1, together with https://github.com/plone/Products.CMFPlone/pull/3981. But let's see if this is okay in 6.0 as well. An issue could be that the contenttypes profile is then applied twice, which may take time, or very maybe break something.

mister-roboto commented 4 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 4 months ago

@jenkins-plone-org please run jobs

One thing to watch out for, is if the jobs take much longer with this PR.