search

plone / plone.app.theming

Integrates the Diazo theming engine with Plone
https://docs.plone.org/external/plone.app.theming/docs/index.html
Other
21 stars 30 forks source link

Do not apply the theme transform over every request. #208

Open frapell opened 2 years ago

frapell commented 2 years ago

This is related to gh-207

Accidentally pushed it to plone/master but already reverted the commit and submitting this pull request instead.

mister-roboto commented 2 years ago

@frapell thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

frapell commented 2 years ago

@jenkins-plone-org please run jobs