search

plone / plone.app.theming

Integrates the Diazo theming engine with Plone
https://docs.plone.org/external/plone.app.theming/docs/index.html
Other
21 stars 30 forks source link

Fix AttributeError: module 'wsgiref' has no attribute 'handlers' #231

Closed mauritsvanrees closed 11 months ago

mauritsvanrees commented 11 months ago

This problem in custom.css is usually hidden if plone.app.caching is available. Fixes https://github.com/plone/plone.app.theming/issues/230

And this PR adds the first test for custom.css, which indeed shows this problem. This fixes https://github.com/plone/plone.app.theming/issues/190

mister-roboto commented 11 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 11 months ago

@jenkins-plone-org please run jobs