Modernize and fix Travis config

plone / plone.app.tiles

Plone UI integration for plone.tiles

http://pypi.python.org/pypi/plone.app.tiles

Other

6 stars 7 forks source link

Modernize and fix Travis config #39

Closed mauritsvanrees closed 4 years ago

mauritsvanrees commented 4 years ago

It started failing for various reasons five months ago, see https://travis-ci.org/github/plone/plone.app.tiles/builds/665243610.

Plone 5.0 failed with a version conflict.
All other actual tests passed on all versions.
But code-analysis failed everywhere, except on Py 3.6 where we do not run it.

I now updated it according to https://github.com/collective/buildout.plonetest/blob/master/README.rst Much simpler, only one buildout config file. Code analysis is gone for the moment, but I may add it to this PR later. Plone 5.0 is no longer tested. I do not care about it. We could drop 4.3 as well, but it still seems to work.

mauritsvanrees commented 4 years ago

Initial tests passed on all Plone and Python combinations. Now I added back code-analysis (with fixes, making this a bigger PR) and coverage plus coveralls.

coveralls commented 4 years ago

Coverage increased (+0.4%) to 81.572% when pulling 1f1d04cbe9e1f4652c218ad29e9a69ed8eb589ee on maurits/travis into efde9085ceb3c1e633df0ccccefe7f4e18c7fe13 on master.

mauritsvanrees commented 4 years ago

It works!

mauritsvanrees commented 4 years ago

Notes for reviewers:

Commit 8add2095278b0d3231da894991a0f051bcaf3846 is the biggest one, but it is simply done with black. So maybe you can look at individual commits and skip that one. The individual commits are clearly split, I think.
But you may just want to look at the branch and check if buildout.cfg and .travis.yml are to your liking. Those are the important changes.
And think a minute if you mind that we drop Plone 5.0 support.