plone / plone.app.users

User registration and profile forms for the Plone CMS
https://pypi.python.org/pypi/plone.app.users
14 stars 22 forks source link

122 portrait image file not supported by pil #123

Closed rber474 closed 6 months ago

rber474 commented 8 months ago

Added a validation in the @@personal-information form for the portrait field. If image is not supported by pillow an validation error will be shown.

@erral I haven't added any translations to plone.app.locales because I am not sure what the workflow is.

Running test I was getting an error for the tearDown so added a transaction.commit to setUp in BaseTest.

Please, review it and let me know if I wrong.

mister-roboto commented 8 months ago

@rber474 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

erral commented 8 months ago

I will handle the translation update in p.a.locales.

The worklfow is a bit different and it is handled at the same time for all packages. Thanks for the heads up!

rber474 commented 8 months ago

@jenkins-plone-org please run jobs

rber474 commented 8 months ago

I am not sure the failed Jenkins test is related to this change:

{'en': <Document at /plone/en/test-document>} != {'en': <Document at /plone/en/test-folder/test-document>}