search

plone / plone.app.users

User registration and profile forms for the Plone CMS
https://pypi.python.org/pypi/plone.app.users
14 stars 22 forks source link

z3c.form-based user account fields #4

Closed lentinj closed 11 years ago

lentinj commented 12 years ago

My attempt at turning them into z3c.form fields. All works, although will probably need some tidyup before this is a proper pull request.

The doctests are shared for both forms, and should pass with both.

The main things that should be looked at are CSRF (which I think is agreed to be done in plone.app.z3cform / z3c.form), and a more succinct way of doing the edit-bar tabs. Me and Laurence did look at adding to the viewlet that generates the actual edit-bar, but then it was hidden when the user wasn't allowed to edit content. This could be fixed and resurrected possibly, or maybe a macro to generate the edit-bar would work better.

lentinj commented 11 years ago

Don't want to merge into master, so closing.