search

plone / plone.app.users

User registration and profile forms for the Plone CMS
https://pypi.python.org/pypi/plone.app.users
14 stars 22 forks source link

fixed circular imports in userdataschema.py, move UserDataSchemaProvider... #9

Closed myroslav closed 9 years ago

myroslav commented 11 years ago

... to schemaprovider.py

This is prerequisite for #13706: Memory leak in plip13350-edit-member-schema-ttw. Fixes of the bug trigger circular imports and move of provider to separate python module is required.

garbas commented 11 years ago

@myroslav and @ktarasz have you signed contributors agreement?

myroslav commented 11 years ago

Hi, I do have signet one back on 2006 or something, and snail mailed to Enfold (my plone.org username is interra).

@ktarasz has not signed it yet. Is process less formal already?

garbas commented 11 years ago

https://buildoutcoredev.readthedocs.org/en/latest/agreement.html now you can scan it (after signing it ofcourse) and send it via email.

myroslav commented 11 years ago

ktarasz and vmaksymiv sent their Contributor agreements via e-mail. Any hints what I have to do to be included in plone organization at github with my 6 year old contributor agreement?

On Fri, Sep 20, 2013 at 5:03 PM, Rok Garbas notifications@github.comwrote:

https://buildoutcoredev.readthedocs.org/en/latest/agreement.html now you can scan it (after signing it ofcourse) and send it via email.

— Reply to this email directly or view it on GitHubhttps://github.com/plone/plone.app.users/pull/9#issuecomment-24812390 .

.................................................................................................................................... Myroslav Opyr ▪ CTO ▪ Quintagroup ▪ +1.917.475.4725 ▪ http://quintagroup.com ˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙

davisagli commented 11 years ago

@myroslav you should have commit access on github now.

myroslav commented 11 years ago

Thanks. I do see loads of e-mail notifications from GitHub already ;)

On Tue, Sep 24, 2013 at 5:46 PM, David Glick notifications@github.comwrote:

@myroslav https://github.com/myroslav you should have commit access on github now.

— Reply to this email directly or view it on GitHubhttps://github.com/plone/plone.app.users/pull/9#issuecomment-25010772 .

.................................................................................................................................... Myroslav Opyr ▪ CTO ▪ Quintagroup ▪ +1.917.475.4725 ▪ http://quintagroup.com ˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙˙

myroslav commented 11 years ago

It look like Contributor Agreements are signed and in effect since all @vmaksymiv, @ktarasz and @myroslav had been granted access to plone organization repositories.

@garbas, @davisagli: Should we merge our pending pull requests ourselves, or you'd like to review/discuss them first?

thet commented 10 years ago

@myroslav if this pull-request is still valid, please merge your own into plone:plip13350-edit-member-schema-ttw otherwise, this feature branch might got obsolete through https://github.com/plone/plone.app.users/tree/plip13350-edit-member-schema-ttw-post-z3cform-merge please confirm.

jensens commented 10 years ago

Whats the state of this one?

lentinj commented 10 years ago

Looks like it should either be closed or merged into the 1.2.x branch. The changes aren't relevant for the z3c.form version.