search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

Add some registry settings for datetime options #108

Closed petschki closed 9 years ago

tisto commented 9 years ago

@petschki @thet plone.api is not allowed to use in core. We ship with it but we can't use it. Please amend the code to use the plone.app.registry lookups.

@jaroel we need to set up a jenkins check to make sure plone.api is not used in the core. Otherwise we will not be able to control this. This use case is more complex than grok since we ship with plone.api but we can't use it.

thet commented 9 years ago

@tisto regarding plone.api: that change aims only for the 1.x branch, which will never be part of the core. However, I'd also prefer the plone.app.registry lookup, since this package is quite close to the core.

tisto commented 9 years ago

@thet right. plone.app.widgets has been merged by @vangheem into other plone packages...ok, then I don't care. ;)

thet commented 9 years ago

@petschki - the travis build errors can be fixed with that commit: https://github.com/plone/plone.app.widgets/commit/87e924ce7605cece12177bd6370bdb89ba9e8048

petschki commented 9 years ago

@thet cool ... tests are passing now. note: I've changed the default time interval back to 5 minutes

thet commented 9 years ago

Merged via: https://github.com/plone/plone.app.widgets/commit/1dcfa4880f32c2574baddfc352247f74029f156f