search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

Fixed Travis Sauce Labs setup. #151

Closed mauritsvanrees closed 7 years ago

mauritsvanrees commented 7 years ago

The master branch has been failing for a long time with this error:

An error occurred while generating the build script.

https://lint.travis-ci.org was complaining about the addons section. This can be tricky to get right, because the linter errors are not entirely obvious:

In our case, we had dashes in front of the options, and that broke it.

Note: this only needs testing by Travis, not Jenkins.

mauritsvanrees commented 7 years ago

Well, the travis config is at least valid enough now so that travis starts and runs for a couple of minutes. But the setup is very broken. For example import errors for plone.app.contenttypes. And it uses plone.app.widgets 1.8.0 instead of master.

Do we still want to test this in Travis for master?

On the 1.x branch the Travis tests pass. But it only does one test run, not multiple browsers. And it uses bin/test and not bin/test --all so it does not run any robot tests.

vangheem commented 7 years ago

I think it's fine to just test with jenkins.

mauritsvanrees commented 7 years ago

I have removed the files that did anything with Travis. In the repository settings, I changed the master branch to no longer require that Travis tests pass before merging. On Travis I enabled the option to only run when .travis.yml is present. This way the 1.x branch can keep using Travis, which I guess could still be nice because it is working.