search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

fix tinymce options with non-contentish contexts #160

Closed thet closed 7 years ago

thet commented 7 years ago

Fix broken get_tinymce_options when called with non-contentish contexts like form or field contexts.

Fixes: https://github.com/collective/collective.easyform/issues/67

petschki commented 7 years ago

As mentioned in #161 I'd recommend to use self.wrapped_context() from underlying p.a.textfield widget

petschki commented 7 years ago

@thet ok my first comment was Plone 4.3 specific ... master branch of p.a.widgets is slighty different. But anyway shouldn't this issue be fixed in plone.app.z3cform instead by passing the correct wrapped context to get_tinymce_options? https://github.com/plone/plone.app.z3cform/blob/master/plone/app/z3cform/widget.py#L592 ...

thet commented 7 years ago

Hmmm... I agree somewhat.