Fix RichTextWidget for non-contentish context

plone / plone.app.widgets

Integrating plone.widgets into plone

Other

7 stars 38 forks source link

Fix RichTextWidget for non-contentish context #163

Closed petschki closed 7 years ago

petschki commented 7 years ago

see #161 related to #160 but for 1.x branch (Plone 4.3 support)

coveralls commented 7 years ago

Coverage increased (+30.9%) to 74.662% when pulling 17428fb39bab7806bc53a0361f3db357912800e5 on petschki-issue-161 into 764299947476a357cfa1c5374e2c0fca93928eff on 1.x.

petschki commented 7 years ago

@fredvd I've fixed your test issues in #158 with this pull request and picked your z3c.form fix too ... this bit me in the dx tests ... hope thats ok. @thet can you have a look at this? This obsoletes #158 ...

petschki commented 7 years ago

@fredvd @thet may I ping you regarding this one? I would really appreciate closing this and releasing 1.9.2 ... Would help me a lot getting collective.cover further to p.a.widgets ... Please let me know if there are any concerns ...

thet commented 7 years ago

looks very good to me. I'm merging.

fredvd commented 7 years ago

@petschki Ah, thanks for fixing the testing issues! I should get my notifications for github fixed, I think I disabled them all a long time ago because of the collective notifications.

thet commented 7 years ago

@fredvd I've set all to "watching" (but get the mails to a dedicated email address) https://gist.github.com/thet/c1ce413bdabc771cba1b