Unset and reset ``define`` and ``require``

plone / plone.app.widgets

Integrating plone.widgets into plone

Other

7 stars 38 forks source link

Unset and reset ``define`` and ``require`` #167

Closed thet closed 7 years ago

thet commented 7 years ago

Unset and reset define and require before and after the plone.app.widgets JavaScript bundle. This avoids the infamous Mismatched anonymous define error with unbundled JavaScript supporting RequireJS. See: http://requirejs.org/docs/errors.html#mismatch

coveralls commented 7 years ago

Coverage remained the same at 74.705% when pulling 74441ab46a86002c2969926d2e4e29079e2b1e78 on thet-requirejs-unset into 6fc477469f5acdea34dafd31d5deaebd299f5abc on 1.x.

petschki commented 7 years ago

btw. which mockup version have our mockup resources? I've seen some significant improvements in RelatedItemsWidget on 2.5.0 (unreleased) ... can we update here too?

coveralls commented 7 years ago

Coverage decreased (-0.05%) to 74.403% when pulling 06fe24d11fdfc487d830b0d50d87f7755720a619 on thet-requirejs-unset into 72893900d86e96d82eaf572c6e2950efa291a376 on 1.x.

thet commented 7 years ago

Tnx for the feedback, I'm merging.

Regarding the mockup version - I'm unsure if we can upgrade. Probably yes - we have to try.