Thet requirejs unset improve

plone / plone.app.widgets

Integrating plone.widgets into plone

Other

7 stars 38 forks source link

Thet requirejs unset improve #170

Closed thet closed 7 years ago

thet commented 7 years ago

followup of https://github.com/plone/plone.app.widgets/pull/169

petschki commented 7 years ago

@thet may I suggest a little improvement for this pull request: can we insert the ++resource++plone.app.widgets.js resource before ++resource++plone.app.jquery.js ... this makes life easier when testing other addons (like collective.cover nona ;) because they use plone.app.jqueryui which installes after plone.app.jquery.js where jQuery is undefined ...

coveralls commented 7 years ago

Coverage remained the same at 74.698% when pulling b0c4b85754a1e18a3369819d2afae1edbfdf01b1 on thet-requirejs-unset-improve into 22e6e15db95cb18e78ae3e85d5158904ec907464 on 1.x.