search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

Included buildout.cfg doesn't start up because of missing plone.app.relationfield #172

Open fredvd opened 7 years ago

fredvd commented 7 years ago

Hello @thet, in https://github.com/plone/plone.app.widgets/pull/168 you've added support for more related items widgets.

When I check out the plone.app.widgets repo locally, build and try to run bin/instance fg I get the following zcml error on startup (last lines)

  File "/Users/fred/.buildout/eggs/zope.configuration-3.7.4-py2.7.egg/zope/configuration/fields.py", line 229, in fromUnicode
    raise InvalidToken("%s in %s" % (v, u))
zope.configuration.xmlconfig.ZopeXMLConfigurationError: File "/Users/fred/buildouts/plone.app.widgets/parts/instance/etc/site.zcml", line 15.2-15.55
    ZopeXMLConfigurationError: File "/Users/fred/buildouts/plone.app.widgets/parts/instance/etc/package-includes/002-plone.app.widgets-configure.zcml", line 1.0-1.61
    ZopeXMLConfigurationError: File "/Users/fred/buildouts/plone.app.widgets/plone/app/widgets/configure.zcml", line 242.4-246.10
    ConfigurationError: ('Invalid value for', 'for', "ImportError: Couldn't import z3c.relationfield.interfaces, No module named relationfield.interfaces in z3c.relationfield.interfaces.IRelationChoice              plone.app.widgets.interfaces.IWidgetsLayer")

In the local buildout plone.app.relationfield is not included in the instance. p.a.relationfield has the dependency on z3c.relationfield. The nasty thing is that bin/test does work locally, so the pull request got accepted/green from travis.. :-S

There might be missing conditions around https://github.com/plone/plone.app.widgets/blob/1.x/plone/app/widgets/configure.zcml#L242-L257 for an installed plone.app.relationfield just like the next lines after 257, but the weirder thing is why plone.app.relationfield isn't pulled locally at all.

Do you by chance develop plone.app.widgets 1.x inside another project buildout?