search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

get_ajaxselect_options is no longer used in plone.app.z3cform #194

Closed jensens closed 5 years ago

jensens commented 5 years ago

Deprecate it.

Refactor get_relateditems_options to be more specific.

More cleanup would be needed.

mister-roboto commented 5 years ago

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

gforcada commented 5 years ago

@jenkins-plone-org please run jobs

jensens commented 5 years ago

@gforcada this need to be run together with other PRs and theres still a problem left as I found at my last run.

pbauer commented 5 years ago

I saw the same issue as jenkins did during some job: Rendering the relateditems widgets with a previously set value breaks.

  File "/home/gitlab-runner/builds/44df7dbf/0/kbo/kbo-buildout/src-mrd/plone.app.z3cform/plone/app/z3cform/widget.py", line 116, in render
    _base_args = self._base_args()
  File "/home/gitlab-runner/builds/44df7dbf/0/kbo/kbo-buildout/src-mrd/plone.app.z3cform/plone/app/z3cform/widget.py", line 599, in _base_args
    field_name,
  File "/home/gitlab-runner/builds/44df7dbf/0/kbo/kbo-buildout/src-mrd/plone.app.widgets/plone/app/widgets/utils.py", line 144, in get_relateditems_options
    'v': value.split(separator)
  File "/home/gitlab-runner/builds/44df7dbf/0/kbo/kbo-buildout/src-mrd/plone.app.vocabularies/plone/app/vocabularies/catalog.py", line 635, in __call__
    parsed = parseQueryString(context, query['criteria'])
TypeError: list indices must be integers, not str
jensens commented 5 years ago

Yes, I am aware. It's not ready yet.

pbauer commented 5 years ago

Looks good to me.

jensens commented 5 years ago

5.1 failure see plone/jenkins.plone.org#258 - this is no blocker for merging!