search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

fix commented out syntax (was a invalid heading) #197

Closed pbauer closed 2 years ago

pbauer commented 5 years ago

That creates errrors with newest versions of robotframework:

[ ERROR ] Error in file '/Users/pbauer/.cache/buildout/eggs/plone.app.widgets-3.0.0-py3.7.egg/plone/app/widgets/tests/robot/test_querystring_widget.robot': Unrecognized table header 'Comment out until we can figure out what is wrong with this test...'. Available headers for data: 'Setting(s)', 'Variable(s)', 'Test Case(s)', 'Task(s)' and 'Keyword(s)'. Use 'Comment(s)' to embedded additional data.
mister-roboto commented 5 years ago

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

pbauer commented 5 years ago

@jenkins-plone-org please run jobs

pbauer commented 5 years ago

@jenkins-plone-org please run jobs

pbauer commented 5 years ago

@jenkins-plone-org please run jobs

pbauer commented 5 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

the test got uncommented and fixed here #214