search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

Solve TinyMCE bug not allowing to enter links on images #202

Open laithmassoud opened 4 years ago

laithmassoud commented 4 years ago

The fix was lifted from this thread in 2017:

https://community.plone.org/t/cant-insert-link-on-image-plone-5-0-6/4322/7

thet commented 12 months ago

Hi, sorry for the late reply.

Is this fix still relevant for you?

You're patching a generated build. When updating widgets.js from Mockup (Mockup version 2.x) this patch would be overwritten again.

So a better fix would be to create a patch with diff which can be applied with patch. The fix could go into plone.app.widgets 1.x or to Mockup 2.x.

Note that both versions are quite old and already unmaintained. But I'd merge a PR with a fix as described above. This PR isn't sustainable and would be overwritten if someone builds a new bundle from Mockup, so this should better live in your branch, IMO.