search

plone / plone.app.widgets

Integrating plone.widgets into plone
Other
7 stars 38 forks source link

PLIP 2150 #205

Closed jensens closed 2 years ago

jensens commented 3 years ago

branch by @thet - it is used in a customer project:

Change plone.app.widgets.utils.get_date_options and plone.widgets.utils.get_datetime_options to reflect settings of new pat-date-picker and pat-datetime-picker.

see https://github.com/plone/Products.CMFPlone/issues/2150

mister-roboto commented 3 years ago

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

thet commented 2 years ago

@petschki I think this should not be merged. The changes here are already in master. I'd be happy if this branch can still exist a little longer, to check if we can just close it.

petschki commented 2 years ago

so you could safely close this PR and let the branch stay alive 🕺🏻

jensens commented 2 years ago

I created a simple branch protection so it wont get deleted accidentally and close this PR now.