search

plone / plone.app.workflowmanager

GUI for managing custom workflows in Plone
12 stars 11 forks source link

2.1.1 doesn't save workflow #65

Open djowett opened 5 years ago

djowett commented 5 years ago

Not sure what I'm doing wrong, but if I do this:

1) create a new workflow (from plone intranet folders) 2) edit a state 3) uncheck some permission roles 4) save 5) return to permission roles in the same state => then my changes in 3) are not there!

tkimnguyen commented 5 years ago

Hi Daniel! Which Plone version, and does it behave this way on one of the shipped workflows?

agitator commented 5 years ago

can confirm with Plone 5.1.5

djowett commented 5 years ago

Hi Kim, it's plone 5.1.4.

I will need to check on shipped workflow later, unless @agitator can confirm.

Cheers, Daniel

On 15 February 2019 04:14:09 GMT, "T. Kim Nguyen" notifications@github.com wrote:

Hi Daniel! Which Plone version, and does it behave this way on one of the shipped workflows?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/plone/plone.app.workflowmanager/issues/65#issuecomment-463899953

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

djowett commented 5 years ago

Hey Kim, it also happens with a shipped workflow - confirmed with "Single State Workflow".

Ta, Daniel

tkimnguyen commented 5 years ago

Ok thanks for checking! I will eventually find the time to take a stab at this and the 5.1 compatibility issue but I can’t promise when – sorry, crunched for other work

tkimnguyen commented 5 years ago

I'm testing with Plone 5.1.5 and Workflow Manager 2.1.1. I cloned the simple publication workflow. I edited the Pending Review state:

Both changes seem to be saved and persist.

tkimnguyen commented 5 years ago

@djowett, @agitator can you give me an exact sequence of actions to replicate this with a plain Plone site with only workflow manager on it?

djowett commented 5 years ago

Hi Kim,

thanks for persisting with this. I've checked and it seems to error more with Firefox not Chromium for me. I did reproduce it on a plain Plone site just now.

When working with Firefox the Save button doesn't go red after you hit "OK", so I didn't realise that was required until using this with Chromium. I think there's 2 issues here

1) On Chromium or Firefox - edit state permissions and press OK. Don't press save - go back into the State - and the permissions have reverted. I think this is unexpected.

2) On Firefox only - edit state permissions and press OK. The Save button doesn't go red. Press it anyway - but it doesn't save. Go back into the State - and the permissions have reverted.

I think there's JS / CSS issues, I've noticed at least: 1) update_form doesn't fire in Firefox - because closer isn't set for some reason 2) CSS error here https://github.com/plone/plone.app.workflowmanager/blob/2.1.2/src/plone/app/workflowmanager/browser/resources/bootstrap-orig.css#L811

HTH!