search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

disable TinyMCE advlist plugin, it produces unclean inline styles #21

Closed MrTango closed 2 years ago

MrTango commented 2 years ago

This plugin should not be used at all, but at least not by default. It does everything with inline styles. The recommended way to do table styling is with the formats, similar to how we did it since Plone 4.

mister-roboto commented 2 years ago

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 2 years ago

+1 do we need an upgrade step for this?

MrTango commented 2 years ago

@jenkins-plone-org please run jobs

MrTango commented 2 years ago

+1 do we need an upgrade step for this?

not sure what is better, if we have one, we will change the setting, even if the user wants somthing else. I would just go without, for all new sites.