plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

Cleanup patterns settings #33

Closed thet closed 3 months ago

thet commented 1 year ago

Together: https://github.com/plone/Products.CMFPlone/pull/3765 https://github.com/plone/plone.base/pull/33 https://github.com/plone/plone.api/pull/504 https://github.com/plone/plone.app.upgrade/pull/328

Jenkins: https://jenkins.plone.org/job/pull-request-6.0-3.11/500

mister-roboto commented 1 year ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 3 months ago

I have rebased on main.