search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

Remove action property `modal` default value. #49

Closed petschki closed 1 year ago

petschki commented 1 year ago

fixes https://github.com/plone/Products.CMFPlone/issues/3801

mister-roboto commented 1 year ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 1 year ago

@jenkins-plone-org please run jobs

petschki commented 1 year ago

@jenkins-plone-org please run jobs