search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

add help as a base option for tinymce plugins #41 #58

Closed rber474 closed 7 months ago

rber474 commented 7 months ago

Updated from master and recreating changes

mister-roboto commented 7 months ago

Rafael Bermudez Horcajada your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

mister-roboto commented 7 months ago

@rber474 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

rber474 commented 7 months ago

Hi @mauritsvanrees @ableeb , Plone Contributors Agreement verifier failed but I signed it months ago.

mister-roboto commented 7 months ago

Rafael Bermudez Horcajada your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

stevepiercy commented 7 months ago

@rber474 would you please check the email on you PCA against the email on your GitHub account. Do they match? It is also possible that the person transferring your email from your PCA into the system made a mistake. Can you contact agreements@plone.org to verify?

FWIW, your GitHub account is a member of @plone/developers team.

rber474 commented 7 months ago

Ohhh global config of email account in company laptop! Sorry guys!

rber474 commented 7 months ago

@jenkins-plone-org please run jobs

rber474 commented 7 months ago

Close to fix commits