search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

Allow including js in head section #60

Closed jladage closed 5 months ago

jladage commented 6 months ago

Fixes https://github.com/plone/Products.CMFPlone/issues/3931

mister-roboto commented 6 months ago

@jladage thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy commented 6 months ago

@jladage see Change log entry.

I don't know why lint fails in CI.

The pre-commit.ci caught the same spelling error that I caught.

jladage commented 6 months ago

@jenkins-plone-org please run jobs

jladage commented 6 months ago

@stevepiercy All checks now pass, but merging remains blocked. Should you do something to accept the change request? Sorry, I lack some experience with these features of github. ;)

stevepiercy commented 6 months ago

@jladage in the future, include "Fixes #[issue number] in your PR description. This enables automatic closing of the related issue when the pull request is merged. This also creates a hyperlink to the original issue for easy reference. I edited your description accordingly.

mauritsvanrees commented 6 months ago

@erral FYI After merging, this would need an update of plone.app.locales for two updated messages and two new ones.

jensens commented 6 months ago

Does this need a migration in plone.app.upgrade?

mauritsvanrees commented 6 months ago

Does this need a migration in plone.app.upgrade?

Yes, this is already there: https://github.com/plone/plone.app.upgrade/pull/323