search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

Enable TinyMCE Editor Plugin 'accordion' #63

Closed 1letter closed 5 months ago

1letter commented 6 months ago

see https://github.com/plone/Products.CMFPlone/issues/3935

should only be merged with a propper upgrade step in plone.app.upgrades

add new values to ITinyMCEPluginSchema an IFilterSchema

mister-roboto commented 6 months ago

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

1letter commented 6 months ago

LGTM, are you going to add the the upgrade step?

Yes, there is available here: https://github.com/plone/plone.app.upgrade/pull/325

jensens commented 5 months ago

both merged