search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

Remove 'Discussion Item' from SearchSchema (helps also to turn pa.discussion into a core addon) #65

Closed jensens closed 4 months ago

jensens commented 4 months ago

With plone.app.discussion Discussion Item is not available by default.

But: "TempFolder" and "Plone Site" are at no time in the constraint vocabulary used. So I removed them as well.

see https://github.com/plone/plone.app.discussion/pull/211
This one can be merged alone and is valid for 6.0 too.

mister-roboto commented 4 months ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 4 months ago

@jenkins-plone-org please run jobs

jensens commented 4 months ago

@jenkins-plone-org please run jobs

jensens commented 4 months ago

@jenkins-plone-org please run jobs