search

plone / plone.base

Plone Interface contracts, plus basic features and utilities
https://pypi.org/project/plone.base
2 stars 0 forks source link

Sane defaults to address: Deleted users keep the roles they had #67

Open jensens opened 3 months ago

jensens commented 3 months ago

see https://github.com/plone/Products.CMFPlone/issues/3937

mister-roboto commented 3 months ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 3 months ago

@jenkins-plone-org please run jobs

jensens commented 3 months ago

Probably there are some failing tests... lets see

davisagli commented 3 months ago

@jensens I want to do some testing in volto before I review this.

jensens commented 3 months ago

if we change the defaults here in plone.base, and plone.restapi and plone.api flat out ignore this, it is not very helpful.

Because the implementation is wrong. This needs a separate fix.

jensens commented 3 months ago

@jenkins-plone-org please run jobs